Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Impact Score Metric #1033

Merged
merged 19 commits into from
Jul 18, 2022
Merged

Impact Score Metric #1033

merged 19 commits into from
Jul 18, 2022

Conversation

Amatullah
Copy link
Contributor

@Amatullah Amatullah commented Jul 12, 2022 •
edited
Loading

Changes Proposed:

Add new metric called Impact Score to get relevant sub-dimensions for anomaly drilldowns and alerts.

Technical Design Document: Alerts Phase 3 TDD

Changes:

  • Add Impact Score changes to controller.py and processor.py
  • DB Migration to add impact_score column to anomaly_data_output table
  • Update Drilldowns query
  • Update Alerts relevant subdims code
  • Update existing anomaly tests

@gitpod-io
Copy link

gitpod-io bot commented Jul 12, 2022

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 2bf97cc
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62d4e7b293d91d0008586a01

@Amatullah Amatullah marked this pull request as draft July 12, 2022 08:09
@Amatullah Amatullah added ✨ enhancement New feature or request 🛠️ backend ❗alerts Alert formatting, scheduling, etc. labels Jul 12, 2022
@Amatullah Amatullah added this to the v0.10.0 milestone Jul 12, 2022
@Amatullah Amatullah self-assigned this Jul 12, 2022
Samyak2
Samyak2 reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few comments

@Amatullah Amatullah requested a review from kartikay-bagla July 14, 2022 06:10
@Samyak2 Samyak2 added the ⚠️ has db migration The changes contain a new database migration. Use caution before merging. label Jul 14, 2022
@Amatullah Amatullah marked this pull request as ready for review July 18, 2022 04:52
@Amatullah Amatullah force-pushed the impact-score-calc branch from f7bc0d1 to 2bf97cc Compare July 18, 2022 04:55
kartikay-bagla
kartikay-bagla approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@kartikay-bagla kartikay-bagla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Samyak2
Samyak2 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samyak2 Samyak2 merged commit 8f02423 into develop Jul 18, 2022
@Samyak2 Samyak2 deleted the impact-score-calc branch July 18, 2022 07:20
@Amatullah Amatullah linked an issue Jul 25, 2022 that may be closed by this pull request
[FEAT]: Better drilldown results for users #931
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@kartikay-bagla kartikay-bagla kartikay-bagla approved these changes

@Samyak2 Samyak2 Samyak2 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Amatullah Amatullah

Labels
❗alerts Alert formatting, scheduling, etc. 🛠️ backend ✨ enhancement New feature or request ⚠️ has db migration The changes contain a new database migration. Use caution before merging.
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

[FEAT]: Better drilldown results for users
3 participants
@Amatullah @kartikay-bagla @Samyak2