Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Schedule Deepdrills/summary at same time as anomaly for daily running KPIs #1034

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Schedule Deepdrills/summary at same time as anomaly for daily running KPIs #1034

merged 3 commits into from
Jul 14, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Jul 12, 2022 •
edited
Loading

Fixes

  • Deepdrills and anomaly were out of sync even for KPIs which are configured to run daily. This lead to one day difference between the data shown in summary vs anomaly. Fixed by making summary schedule time same as anomaly schedule time for daily model frequency KPIs.
  • Existing KPIs are modified through a migration
  • New KPIs and KPIs whose anomaly configuration is modified are handled in the API
  • Also fixed old TODO of converting anomaly_params to JSONB

Dependencies

@Samyak2 Samyak2 added 🛠️ backend don't merge PR which doesn't need to be merged right now labels Jul 12, 2022
@Samyak2 Samyak2 added this to the v0.10.0 milestone Jul 12, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jul 12, 2022

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 51b73a8
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62d00c469561950009d4a7ec

@Samyak2 Samyak2 force-pushed the fix/schedule-summary-at-daily-anomaly-run branch from 0e1b8d0 to 747fda4 Compare July 13, 2022 03:38
@Samyak2 Samyak2 removed the don't merge PR which doesn't need to be merged right now label Jul 13, 2022
@Samyak2 Samyak2 requested a review from varunp2k July 13, 2022 03:40
@Samyak2 Samyak2 added the ⚠️ has db migration The changes contain a new database migration. Use caution before merging. label Jul 14, 2022
varunp2k
varunp2k reviewed Jul 14, 2022
View reviewed changes
Copy link
Member

@varunp2k varunp2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are writing a migration, can we also change the datatype to JSONB instead of just JSON?

@varunp2k varunp2k marked this pull request as draft July 14, 2022 12:05
@Samyak2 Samyak2 marked this pull request as ready for review July 14, 2022 12:31
@Samyak2 Samyak2 requested a review from varunp2k July 14, 2022 12:31
varunp2k
varunp2k approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@varunp2k varunp2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@varunp2k varunp2k merged commit 28c4114 into develop Jul 14, 2022
@Samyak2 Samyak2 deleted the fix/schedule-summary-at-daily-anomaly-run branch July 14, 2022 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@varunp2k varunp2k varunp2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🛠️ backend ⚠️ has db migration The changes contain a new database migration. Use caution before merging.
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Samyak2 @varunp2k