Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

fix(anomaly): smaller time window, drop dups for hourly KPI drilldown #1029

Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix(anomaly): smaller time window, drop dups for hourly KPI drilldown #1029

merged 1 commit into from
Jul 12, 2022

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Jul 11, 2022

Fixes #1028

  • Use a 3 hour time window (6 points) for hourly KPIs, instead of the default 1 day (48 points).
  • The time window could cause multiple entries of the same subdim to be shown in the drilldown. To avoid this, we drop duplicate subdims and keep only the first (after sorting).

@Samyak2
fix(anomaly): smaller time window, drop dups for hourly KPI drilldown
ac0b80e 
Fixes #1028

- Use a 3 hour time window (6 points) for hourly KPIs, instead of the
  default 1 day (48 points).
- The time window could cause multiple entries of the same subdim to be
  shown in the drilldown. To avoid this, we drop duplicate subdims and
  keep only the first (after sorting).
@Samyak2 Samyak2 added 🐛 bug Something isn't working 🛠️ backend labels Jul 11, 2022
@Samyak2 Samyak2 added this to the v0.10.0 milestone Jul 11, 2022
@Samyak2 Samyak2 requested a review from Amatullah July 11, 2022 15:03
@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2022

@netlify
Copy link

netlify bot commented Jul 11, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb ready!

Name Link
🔨 Latest commit ac0b80e
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62cc3bbe1cc648000804b580
😎 Deploy Preview https://deploy-preview-1029--frontend-sb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Amatullah
Amatullah approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@Amatullah Amatullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amatullah Amatullah merged commit 4643a29 into develop Jul 12, 2022
@Amatullah Amatullah deleted the fix/anomaly-drilldown-duplicates branch July 12, 2022 05:40
@Samyak2 Samyak2 linked an issue Jul 14, 2022 that may be closed by this pull request
[BUG] Drilldowns sometimes show multiple entries of the same sub-dimension #1028
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@Amatullah Amatullah Amatullah approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🛠️ backend 🐛 bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

[BUG] Drilldowns sometimes show multiple entries of the same sub-dimension
2 participants
@Samyak2 @Amatullah