Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Conversation

Samyak2
Copy link
Contributor

@Samyak2 Samyak2 commented Jul 6, 2022

Changes

  • "Sub-dimensional anomalies" heading was present even when there weren't any subdim anomalies in individual alerts.
  • "Reasons for change" text was present even when there weren't any relevant subdims.

Notes for reviewers

See diff without code formatting changes: 06da2ff...fix/alerts-relevant-subdims-empty

Samyak2 added 2 commits July 6, 2022 19:13
"Sub-dimensional anomalies" heading was present even when there weren't
any subdim anomalies in individual alerts.

"Reasons for change" text was present even when there weren't any
relevant subdims.
@Samyak2 Samyak2 added 🐛 bug Something isn't working ❗alerts Alert formatting, scheduling, etc. labels Jul 6, 2022
@Samyak2 Samyak2 requested a review from Amatullah July 6, 2022 13:49
@gitpod-io
Copy link

gitpod-io bot commented Jul 6, 2022

@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 3f91682
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/62c592d7f322fa0009897506

@Samyak2 Samyak2 added this to the v0.9.1 milestone Jul 6, 2022
Copy link
Contributor

@Amatullah Amatullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amatullah Amatullah merged commit 86e3a82 into develop Jul 6, 2022
@Amatullah Amatullah deleted the fix/alerts-relevant-subdims-empty branch July 6, 2022 18:21
@Samyak2 Samyak2 mentioned this pull request Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
❗alerts Alert formatting, scheduling, etc. 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants