Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Subdim filter fe #1002

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Subdim filter fe #1002

merged 6 commits into from
Jun 22, 2022

Conversation

ChartistDev
Copy link
Contributor

Visual overhaul anomaly page:

  1. Removed overall KPI/ Sub-dimension tab
  2. Added select boxes for dimension and value

@ChartistDev ChartistDev requested a review from manassolanki June 20, 2022 13:34
@ChartistDev ChartistDev self-assigned this Jun 20, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jun 20, 2022

Base automatically changed from subdim-filter to develop June 22, 2022 04:53
@manassolanki
Copy link
Member

LGTM
Just one small feedback, when we will be adding some subdimension, then the download button should provide the data for that subdimension or not? Right now, it is giving the perception that the data for that subdimension will be downloaded which isn't the case.
Have we thought through this? @Amatullah @Samyak2

@ChartistDev
Copy link
Contributor Author

@manassolanki we will probably take that feature in the next release.

@manassolanki
Copy link
Member

@manassolanki we will probably take that feature in the next release.

Can we document this decision somewhere (PRD/TDD/TODO)?

@manassolanki manassolanki merged commit 92630ff into develop Jun 22, 2022
@Samyak2 Samyak2 added this to the v0.9.0 milestone Jun 28, 2022
@Amatullah Amatullah deleted the subdim-filter-FE branch June 28, 2022 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@manassolanki manassolanki manassolanki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ChartistDev ChartistDev

Labels
🖥️ frontend
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ChartistDev @manassolanki @Samyak2