Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Configurable Datetime format and SQL strings in Data Loader #962

Merged
merged 8 commits into from
May 24, 2022
Merged

Configurable Datetime format and SQL strings in Data Loader #962

merged 8 commits into from
May 24, 2022

Conversation

kartikay-bagla
Copy link
Contributor

  • Moved SQL identifiers to their respective connectors
  • Added Date and timestamp formatting strings in connectors
  • Updated data loader to work with these
  • Formatted all files used to be consistent with style guidelines.

@kartikay-bagla kartikay-bagla added 🛠️ backend 🔗 connectors DB, DW & third party connectors labels May 24, 2022
@kartikay-bagla kartikay-bagla added this to the v0.8.0 milestone May 24, 2022
@kartikay-bagla kartikay-bagla self-assigned this May 24, 2022
@netlify
Copy link

netlify bot commented May 24, 2022 •
edited
Loading

✅ Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit 45c310d
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/628ca27456e6e8000986535c

@gitpod-io
Copy link

gitpod-io bot commented May 24, 2022

Samyak2
Samyak2 suggested changes May 24, 2022
View reviewed changes
@kartikay-bagla kartikay-bagla requested a review from Samyak2 May 24, 2022 06:03
Samyak2
Samyak2 approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

manassolanki
manassolanki suggested changes May 24, 2022
View reviewed changes
@manassolanki
Copy link
Member

manassolanki commented May 24, 2022 •
edited
Loading

@kartikay-bagla PR to main? Can you rebase to develop?

@kartikay-bagla kartikay-bagla changed the base branch from main to develop May 24, 2022 11:33
@kartikay-bagla
Copy link
Contributor Author

fixed.

@manassolanki
Copy link
Member

LGTM

@kartikay-bagla kartikay-bagla merged commit 3b77dc1 into develop May 24, 2022
@kartikay-bagla kartikay-bagla deleted the feature/configurable-timestrings-dataloader branch May 24, 2022 11:34
bhargavsk1077 added a commit that referenced this pull request May 24, 2022
@bhargavsk1077
fix: Revert data loader changes.
87deaf5 
Restored the previous state of
`chaos_genius/core/utils/data_loader.py`
as the changes have been covered in the PR - #962
Samyak2 added a commit that referenced this pull request May 25, 2022
@Samyak2
fix(connectors): use custom datetime formats for Trino
979657b 
Changed to use the refactors in #962, #963
@Echo9k
Copy link

Echo9k commented Dec 26, 2022

Im getting an error I belive could be an extension of this issue.
I get this error while traying to create my first KPI from a BigQuery Table
Could not cast literal "2022-10-27T00:00:00" to type DATE at [1:53]

The timestamp format in BigQuery looks like this "2008-12-25 05:30:00+00"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@Samyak2 Samyak2 Samyak2 approved these changes

@manassolanki manassolanki manassolanki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kartikay-bagla kartikay-bagla

Labels
🛠️ backend 🔗 connectors DB, DW & third party connectors
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kartikay-bagla @manassolanki @Echo9k @Samyak2