This repository was archived by the owner on Sep 12, 2024. It is now read-only.
refactor(alert-view): fix flake8, isort, formatting, type errors #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frontend-sb canceled.
|
- formatted using black and isort
- fixed type errors
- check the value returned by `get_json()` is None before using it
- returns a message with 400 if it's not a JSON
- fixed flake8 errors
- fixed docstrings
- create a new logger for the alert view module instead of using the
root logger (`current_app.logger`)
- reduced total errors and warnings from 60+ to 0
de56334 to
80a9820
Compare
Merged
varunp2k
reviewed
Apr 29, 2022
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_json()is None before using itcurrent_app.logger)