-
Notifications
You must be signed in to change notification settings - Fork 87
build: docker-compose update for development #856
Conversation
Mount local files into container, gunicorn autoreloads on file changes add celerybeat-schedule.db to .gitignore mound docker.sock to silence celery worker errors in log
✅ Deploy Preview for frontend-sb canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have auto-reload for celery workers and scheduler too. Refer:
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
2745890 | Generic High Entropy Secret | f0c2eec | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. A few changes in the newly added compose files may be required.
…D` True for thirdparty
ignoring gitguardian warning for now , have asked @manassolanki to take care of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a couple of more things now
…er compose files, fix version str in thirdparty dev compose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Mount local files into container, gunicorn autoreloads on file changes
add celerybeat-schedule.db to .gitignore
mound docker.sock to silence celery worker errors in log
Iteration 2
DEV
build arg for Dev build ( installs dev dependencies fromrequirements/dev.txt
)