Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Conversation

rjdp
Copy link
Contributor

@rjdp rjdp commented Mar 29, 2022

Mount local files into container, gunicorn autoreloads on file changes
add celerybeat-schedule.db to .gitignore
mound docker.sock to silence celery worker errors in log

Iteration 2

  • Use autoreload clery-worker scripts for dev docker-compose
  • Use DEV build arg for Dev build ( installs dev dependencies from requirements/dev.txt )
  • Add dev docker-compose file for third-party

Mount local files into container, gunicorn autoreloads on file changes
add celerybeat-schedule.db to .gitignore
mound docker.sock to silence celery worker errors in log
@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for frontend-sb canceled.

Name Link
🔨 Latest commit bf04072
🔍 Latest deploy log https://app.netlify.com/sites/frontend-sb/deploys/625569417a468f00083cc6fb

@rjdp rjdp requested a review from Samyak2 March 29, 2022 13:56
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitguardian
Copy link

gitguardian bot commented Apr 11, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2745890 Generic High Entropy Secret f0c2eec .env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rjdp rjdp requested a review from Samyak2 April 11, 2022 14:19
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A few changes in the newly added compose files may be required.

@rjdp rjdp requested a review from Samyak2 April 12, 2022 07:08
@rjdp
Copy link
Contributor Author

rjdp commented Apr 12, 2022

ignoring gitguardian warning for now , have asked @manassolanki to take care of it

@rjdp rjdp added the 🏗️ infrastructure infrastructure, devops, setup, etc. label Apr 12, 2022
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple of more things now

…er compose files, fix version str in thirdparty dev compose
@rjdp rjdp requested a review from Samyak2 April 12, 2022 11:58
Copy link
Contributor

@Samyak2 Samyak2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Samyak2 Samyak2 merged commit 7da971b into develop Apr 12, 2022
@Samyak2 Samyak2 deleted the dev-docker-compose branch April 12, 2022 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏗️ infrastructure infrastructure, devops, setup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants