Upgrade Semaphore CI image to 22.04 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the Ubuntu 22.04 semaphore image doesn't have python 3.9 installed, we can use Docker instead like we do for other python versions: https://github.com/channable/heliclockter/blob/master/.semaphore/semaphore.yml#L39 |
evroon
reviewed
Feb 3, 2025
Comment on lines
-24
to
-29
| - "export PUBLISH_JUNIT_REPORT=true" # Export junit report from this job | ||
| - "python3.9 -m pip install -e .[all]" | ||
| - "python3.9 -m pytest tests" | ||
| # Test without pydantic as well | ||
| - "python3.9 -m pip uninstall pydantic -y" | ||
| - "python3.9 -m pytest tests --ignore-glob \"./tests/pydantic_*.py\"" |
There was a problem hiding this comment.
Ah now we don't have this mechanism anymore where we run tests with and without pydantic anymore. Could you move that to the latest version of Python that's supported on this ubuntu2204 image?
evroon
approved these changes
Feb 3, 2025
|
@OpsBotPrime merge |
Approved-by: nishit-ndgr Priority: Normal Auto-deploy: false
|
Rebased as 0d85df5, waiting for CI … |
|
CI job 🟡 started. |
dfe15ad to
0d85df5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #12385
Upgrades Semaphore CI image from 20.04 to 22.04