Additional files can be zipped in with miniwdl zip. Fix for cross-device link error. #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4924706285
💛 - Coveralls |
|
Thanks @rhpvorderman, this definitely looks useful. Only suggestion is to error out if an additional file will cause something else to be overwritten. I've hit the problem with |
Done. Luckily python already has a |
0315e3f to
6b76b80
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
...
#640
Approach
Simply add the flag 😉.
There is also one bug fix about an invalid cross-device link that gets triggered because I have my
/homedir on a separate partition. So/tmpand/homeare on different devices and this triggers an invalid cross-device link warning when os.rename is used. I use the higher level shutil.move instead. This bug fix is in a single commit that can be cherry picked.I have not added tests yet because you might have different ideas about how to implement this. I think a "--license" flag to include a license file that also gets added to the manifest would be quite a neat feature for redistributable WDL packages.
Checklist
make prettyto reformat the code with blackmake checkto statically check the code using Pyre and Pylint