Skip to content

fix MapEntry not found error in clj #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix MapEntry not found error in clj #55

merged 2 commits into from
Jan 22, 2024

Conversation

imrekoszo
Copy link
Collaborator

Fixes #54

@imrekoszo
Copy link
Collaborator Author

@cgrand bb test-all passes for me. I don't have ClojureDart to try it out there, would you be able to verify I didn't break that please?

@cgrand
Copy link
Owner

cgrand commented Jan 19, 2024

Go ahead. I won't bother with clojudart being broken until I fix the reader issues that make cljc painful in clojuredart.

@imrekoszo
Copy link
Collaborator Author

Force-pushed to add a test, no change to the fix itself.

@imrekoszo
Copy link
Collaborator Author 

git show --shortstat && bb test-all
commit 3b432f9cec5d84e8593dc8ce5043de3704ce0d48 (HEAD -> issue-54, imre/issue-54)
Author: Imre Kószó <imrekoszo@users.noreply.github.com>
Date:   Mon Jan 22 11:33:34 2024 +0100

    cut 0.19.6

 2 files changed, 9 insertions(+), 1 deletion(-)

Testing net.cgrand.xforms-test

Ran 8 tests containing 42 assertions.
0 failures, 0 errors.
+ clojure -Srepro -M:kaocha:test:clj-1-9
[(...............................................)]
10 tests, 47 assertions, 0 failures.
+ clojure -Srepro -M:kaocha:test:clj-1-10
[(...............................................)]
10 tests, 47 assertions, 0 failures.
+ clojure -Srepro -M:kaocha:test:clj-1-11
[(...............................................)]
10 tests, 47 assertions, 0 failures.

Testing net.cgrand.xforms-test

Ran 8 tests containing 42 assertions.
0 failures, 0 errors.

Testing net.cgrand.xforms-test

Ran 8 tests containing 42 assertions.
0 failures, 0 errors.

@imrekoszo imrekoszo merged commit 18de93c into cgrand:master Jan 22, 2024
@imrekoszo imrekoszo changed the title fix MapEntry not found error in clj/s fix MapEntry not found error in clj Jan 22, 2024
@imrekoszo imrekoszo deleted the issue-54 branch January 22, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression in 0.19.5
2 participants
@imrekoszo @cgrand