Update global section to not have "additionalProperties: false" #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf2d743 to
a1e405a
Compare
This reverts commit 1fc8483. Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
a1e405a to
ec5e984
Compare
maelvls
reviewed
Oct 7, 2024
| @@ -165,7 +162,7 @@ func Render(document *parser.Document) (string, error) { | |||
| } | |||
|
|
|||
| newSchema.SchemaProps.Properties = properties | |||
| if len(level.Children) > 0 { | |||
| if len(level.Children) > 0 && !(paths.Path{}).WithProperty("global").IsSubPathOf(level.Path) { | |||
There was a problem hiding this comment.
Suggestion: Consider adding a comment to clarify the purpose of && !(paths.... Its function may not be immediately clear at first glance.
maelvls
approved these changes
Oct 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
|
New changes are detected. LGTM label has been removed. |
|
/unhold I added the comments. |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted the wrong commits in #42, this PR should fix that.