Skip to content

Remove legacy e2e util functions for Issuer creation #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Remove legacy e2e util functions for Issuer creation #3873

merged 1 commit into from
Apr 9, 2021

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Apr 8, 2021 •
edited
Loading

This PR removes a bunch of legacy functions for issuer generation from test/e2e/util/util.go as it partially duplicated the functionality in test/unit/gen/issuer.go and adds some more specific issuer generation functions to test/unit/gen/issuer.go.

I hope no-one has been importing these legacy functions - I did not find external imports on pkg.go.dev

This PR was originally part of #3850 which is getting split into multiple PRs.

Removes legacy util functions for issuer generation from test/e2e/util/util.go. Use functions in test/unit/gen/issuer.go instead.

/kind cleanup

Signed-off-by: irbekrm irbekrm@gmail.com

@irbekrm irbekrm requested review from SgtCoDFish and JoshVanL April 8, 2021 16:53
@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/testing Issues relating to testing approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 8, 2021
@irbekrm irbekrm mentioned this pull request Apr 8, 2021
Closed
@irbekrm irbekrm force-pushed the remove_legacy_functions branch from 70c2acb to 585c6f7 Compare April 8, 2021 17:06
@irbekrm
Remove legacy e2e util functions for Issuer creation
333f600 
Use test/util/gen instead

Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm irbekrm force-pushed the remove_legacy_functions branch from 585c6f7 to 333f600 Compare April 8, 2021 17:30
@SgtCoDFish
Copy link
Member

/test pull-cert-manager-bazel

@SgtCoDFish
Copy link
Member

SgtCoDFish commented Apr 9, 2021 •
edited
Loading

Since this is technically a breaking change if anyone imports the deleted functions in, say, a closed-source product which wouldn't appear on pkg.go.dev, would it be worth noting that in the release notes?

I agree that the chances of anyone using these functions is really low. In any case if anyone was using the deleted functions they have an easy upgrade path by copying what's been done in this PR.

wallrj
wallrj approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a nice cleanup.
Maybe add a release-note documenting that we've removed those public functions and mention the suggested alternative.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 9, 2021
@irbekrm
Copy link
Contributor Author

irbekrm commented Apr 9, 2021

Thanks @SgtCoDFish , @wallrj !

Agree on release note- I have added that, please take a look.

@SgtCoDFish
Copy link
Member

release notes look good!

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2021
@jetstack-bot jetstack-bot merged commit 1dad685 into cert-manager:master Apr 9, 2021
@jetstack-bot jetstack-bot added this to the v1.4 milestone Apr 9, 2021
@irbekrm irbekrm deleted the remove_legacy_functions branch April 9, 2021 09:24
@maelvls maelvls mentioned this pull request Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

@SgtCoDFish SgtCoDFish Awaiting requested review from SgtCoDFish

@JoshVanL JoshVanL Awaiting requested review from JoshVanL

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@irbekrm @SgtCoDFish @jetstack-bot @wallrj