Skip to content

Update kind images to include the Kubernetes 1.33 node image #7786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2025
Merged

Update kind images to include the Kubernetes 1.33 node image #7786

merged 3 commits into from
Jun 6, 2025

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jun 6, 2025 •
edited
Loading

This allows us to run the cert-manager E2E tests with Kubernetes 1.33, which is the latest version:

I'll also cherry pick this into release-1.18, because it is supposed to be supported and tested on K8S 1.33:

The images were updated automatically as follows:

# Find the version of Kind in use for cert-manager E2E tests
$ _bin/tools/kind version
kind v0.27.0 go1.23.6 linux/amd64

# Supply that version to the latest-kind-images.sh
$ ./hack/latest-kind-images.sh v0.27.0

I've added Kubernetes 1.33 as an optional test to the prow config in cert-manager/testing#1096

You can see the results of the test here:

Note: cert-manager doesn't yet use the kind module from makefile modules:

The images were last updated in #7526:

/kind cleanup

Update kind images to include the Kubernetes 1.33 node image

@wallrj-cyberark
Fix a typo in the make help text
043840f 
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj-cyberark
./hack/latest-kind-images.sh v0.27.0
355a244 
Use the latest-kind-images.sh script to get the latest Kind node images for the
version of Kind:

 $ _bin/tools/kind version
 kind v0.27.0 go1.23.6 linux/amd64

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2025
@wallrj wallrj mentioned this pull request Jun 6, 2025
Merged
@wallrj
Copy link
Member Author

wallrj commented Jun 6, 2025

/test pull-cert-manager-master-e2e-v1-33
/test pull-cert-manager-master-e2e-v1-33-upgrade

@wallrj
Copy link
Member Author

wallrj commented Jun 6, 2025

/test pull-cert-manager-master-e2e-v1-33-upgrade

@cert-manager-prow
Copy link
Contributor

@wallrj: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cert-manager-master-e2e-v1-32

/test pull-cert-manager-master-e2e-v1-32-upgrade

/test pull-cert-manager-master-make-test

/test pull-cert-manager-master-make-verify

The following commands are available to trigger optional jobs:

/test pull-cert-manager-master-e2e-v1-30

/test pull-cert-manager-master-e2e-v1-31

/test pull-cert-manager-master-e2e-v1-32-bestpractice-install

/test pull-cert-manager-master-e2e-v1-32-feature-gates-disabled

/test pull-cert-manager-master-e2e-v1-32-issuers-venafi-cloud

/test pull-cert-manager-master-e2e-v1-32-issuers-venafi-tpp

/test pull-cert-manager-master-e2e-v1-33

/test pull-cert-manager-master-license

Use /test all to run the following jobs that were automatically triggered:

pull-cert-manager-master-e2e-v1-32

pull-cert-manager-master-e2e-v1-32-upgrade

pull-cert-manager-master-make-test

pull-cert-manager-master-make-verify

In response to this:

/test pull-cert-manager-master-e2e-v1-33-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wallrj
Copy link
Member Author

wallrj commented Jun 6, 2025

/test pull-cert-manager-master-e2e-v1-32

@wallrj-cyberark
Add 1.33 option to cluster.sh
b5794bb 
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj
Copy link
Member Author

wallrj commented Jun 6, 2025

/test pull-cert-manager-master-e2e-v1-33

@wallrj wallrj changed the title WIP: Update kind images to include the Kubernetes 1.33 node image Update kind images to include the Kubernetes 1.33 node image Jun 6, 2025
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2025
wallrj
wallrj commented Jun 6, 2025
View reviewed changes
make/kind_images.sh
@@ -12,9 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# generated by "./hack/latest-kind-images.sh v0.26.0"
# generated by "./hack/latest-kind-images.sh v0.27.0"
Copy link
Member Author

@wallrj wallrj Jun 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using v0.26.0 kind node images with Kind v0.27.0 since kind was upgraded in #7669:

This won't happen if we use the Kind module from makefile-modules.

@wallrj
Copy link
Member Author

wallrj commented Jun 6, 2025

/cherry-pick release-1.18

@cert-manager-bot
Copy link
Contributor

@wallrj: once the present PR merges, I will cherry-pick it on top of release-1.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wallrj wallrj requested a review from SgtCoDFish June 6, 2025 15:24
SgtCoDFish
SgtCoDFish approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Seems good to me, cheers!

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2025
@cert-manager-prow cert-manager-prow bot merged commit 5372509 into cert-manager:master Jun 6, 2025
7 checks passed
@wallrj wallrj deleted the update-kind-images branch June 6, 2025 16:04
@cert-manager-bot
Copy link
Contributor

@wallrj: new pull request created: #7787

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-bot cert-manager-bot mentioned this pull request Jun 6, 2025
Merged
@wallrj wallrj mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wallrj @cert-manager-bot @SgtCoDFish @wallrj-cyberark