Skip to content

[release-1.12] Bump x/net to fix CVE-2025-22870 reported by trivy #7624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SgtCoDFish
Copy link
Member

@SgtCoDFish SgtCoDFish commented Mar 14, 2025

Pull Request Motivation

Similar to #7623 and #7622

This ended up expanding to address a couple of other reported issues, too. Each commit should be self-explanatory.

Kind

/kind bug

Release Note

Bump golang.org/x/net to address CVE-2025-22870 reported by Trivy

@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/testing Issues relating to testing size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2025
@SgtCoDFish SgtCoDFish force-pushed the release-1.12-bump-xnet branch from 2930d22 to b3d8555 Compare March 14, 2025 15:04
This ensures that cmrel will be able to parse go1.23.0 directives from 1.23+

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
… trivy

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@SgtCoDFish SgtCoDFish force-pushed the release-1.12-bump-xnet branch from 1762001 to 674ba77 Compare March 19, 2025 16:43
Caused by upstream change. These tests shouldn't be run, but
for now just fix the break

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@cert-manager-prow cert-manager-prow bot added the area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code label Mar 19, 2025
@wallrj wallrj self-requested a review March 19, 2025 17:23
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran trivy locally and noticed that there's one other failure, which we should probably just add to the ignore file, here or in another PR.
There's already an ignore line for a previous timezone issue.

  "Results": [
    {
      "Target": "_bin/containers/cert-manager-controller-linux-amd64.tar (debian 11.10)",
      "Class": "os-pkgs",
      "Type": "debian",
      "Vulnerabilities": [
        {
          "VulnerabilityID": "DLA-4085-1",
          "VendorIDs": [
            "DLA-4085-1"
          ],
          "PkgName": "tzdata",
          "InstalledVersion": "2024a-0+deb11u1",
          "FixedVersion": "2025a-0+deb11u1",
          "Layer": {
            "DiffID": "sha256:9ed498e122b248a801130d052c25418381ee7bf215cdf7990965bae0dc37dcc2"
          },
          "DataSource": {
            "ID": "debian",
            "Name": "Debian Security Tracker",
            "URL": "https://salsa.debian.org/security-tracker-team/security-tracker"
          },
          "Title": "tzdata - new timezone database",
          "Severity": "UNKNOWN"
        }
      ]
    }
  ]
}
make: *** [make/scan.mk:26: trivy-scan-controller] Error 1
$ git grep DLA-
.trivyignore:# DLA-3972-1 refers to an out-of-date timezone database in Debian 11 (bullseye).
.trivyignore:# https://security-tracker.debian.org/tracker/DLA-3972-1
.trivyignore:DLA-3972-1

/approve
/lgtm
/hold in case you also want to add the ignore line here.

@cert-manager-prow cert-manager-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 19, 2025
@SgtCoDFish
Copy link
Member Author

Cheers Richard - I've updated with the ignore and a further update!

@SgtCoDFish SgtCoDFish force-pushed the release-1.12-bump-xnet branch from b95e84f to e16f9b5 Compare March 20, 2025 14:23
@cert-manager-prow cert-manager-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2025
Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@SgtCoDFish SgtCoDFish force-pushed the release-1.12-bump-xnet branch from e16f9b5 to f838c91 Compare March 20, 2025 16:49
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/unhold

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 21, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot merged commit a635006 into cert-manager:release-1.12 Mar 21, 2025
7 checks passed
@SgtCoDFish SgtCoDFish deleted the release-1.12-bump-xnet branch March 21, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants