Skip to content

[release-1.14] Fix backwards incompatible change: include a prometheus service by default #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2024
Merged

[release-1.14] Fix backwards incompatible change: include a prometheus service by default #6703

merged 2 commits into from
Feb 1, 2024

Conversation

SgtCoDFish
Copy link
Member

Manual backport of #6699

Kind

/kind bug

Release Note

NONE

inteon and others added 2 commits February 1, 2024 14:23
@inteon @SgtCoDFish
[release-1.14] fix backwards incompatible change: include a prometheu…
f4901be 
…s service by default

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@inteon @wallrj @SgtCoDFish
[release-1.14] Update deploy/charts/cert-manager/values.yaml
3af8e83 
Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/deploy Indicates a PR modifies deployment configuration size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2024
@inteon
Copy link
Member

inteon commented Feb 1, 2024

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@SgtCoDFish
Copy link
Member Author

/test pull-cert-manager-release-1.14-e2e-v1-29

@jetstack-bot jetstack-bot merged commit 95d6fc4 into cert-manager:release-1.14 Feb 1, 2024
@SgtCoDFish SgtCoDFish deleted the release-1.14-promfix branch February 1, 2024 15:37
@jetstack-bot jetstack-bot mentioned this pull request Feb 1, 2024
Closed
@wallrj wallrj added this to the 1.14 milestone Feb 2, 2024
@cert-manager-prow cert-manager-prow bot mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
4 participants
@SgtCoDFish @inteon @jetstack-bot @wallrj