Skip to content

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jan 12, 2024

This PR cmd/cmctl's go.mod to v1.14.0-alpha.1 as part of the release process.

To the reviewer: the version changes in go.mod must be reviewed.

NONE

Signed-off-by: Richard Wall <richard.wall@venafi.com>
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/testing Issues relating to testing needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
@wallrj
Copy link
Member Author

wallrj commented Jan 12, 2024

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@wallrj wallrj mentioned this pull request Jan 12, 2024
73 tasks
@wallrj wallrj requested a review from maelvls January 12, 2024 16:53
@maelvls
Copy link
Member

maelvls commented Jan 12, 2024

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2024
@wallrj
Copy link
Member Author

wallrj commented Jan 12, 2024

@wallrj
Copy link
Member Author

wallrj commented Jan 12, 2024

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@jetstack-bot jetstack-bot merged commit 7e94b73 into cert-manager:master Jan 12, 2024
@wallrj wallrj deleted the update-cmd/ctl/v1.14.0-alpha.1 branch January 12, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants