Skip to content

Require feature gate in otherName SAN cert e2e #6635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2024
Merged

Require feature gate in otherName SAN cert e2e #6635

merged 1 commit into from
Jan 12, 2024

Conversation

SpectralHiss
Copy link
Contributor

@SpectralHiss SpectralHiss commented Jan 12, 2024 •
edited by wallrj
Loading

Ensures that otherName Certificate e2e test only runs when the feature flag is turned on!

Fixes test running in periodics where we don't use feature flags
https://prow.build-infra.jetstack.net/view/gs/jetstack-logs/logs/ci-cert-manager-master-e2e-v1-23-feature-gates-disabled/1745556152202039296

NONE

Require feature gate in otherName SAN cert e2e
a517dcd 
Signed-off-by: SpectralHiss <houssem.elfekih@jetstack.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2024
@jetstack-bot
Copy link
Contributor

Hi @SpectralHiss. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/testing Issues relating to testing labels Jan 12, 2024
wallrj
wallrj approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/test ci-cert-manager-master-e2e-v1-28-feature-gates-disabled

@jetstack-bot jetstack-bot added ok-to-test approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 12, 2024
@wallrj
Copy link
Member

wallrj commented Jan 12, 2024

/test ci-cert-manager-master-e2e-v1-28-feature-gates-disabled

@jetstack-bot
Copy link
Contributor

@wallrj: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cert-manager-master-chart
  • /test pull-cert-manager-master-e2e-v1-28
  • /test pull-cert-manager-master-e2e-v1-28-upgrade
  • /test pull-cert-manager-master-make-test

The following commands are available to trigger optional jobs:

  • /test pull-cert-manager-master-e2e-v1-23
  • /test pull-cert-manager-master-e2e-v1-24
  • /test pull-cert-manager-master-e2e-v1-25
  • /test pull-cert-manager-master-e2e-v1-26
  • /test pull-cert-manager-master-e2e-v1-27
  • /test pull-cert-manager-master-e2e-v1-28-bestpractice-install
  • /test pull-cert-manager-master-e2e-v1-28-feature-gates-disabled
  • /test pull-cert-manager-master-e2e-v1-28-issuers-venafi-cloud
  • /test pull-cert-manager-master-e2e-v1-28-issuers-venafi-tpp
  • /test pull-cert-manager-master-license

Use /test all to run the following jobs that were automatically triggered:

  • pull-cert-manager-master-chart
  • pull-cert-manager-master-e2e-v1-28
  • pull-cert-manager-master-e2e-v1-28-upgrade
  • pull-cert-manager-master-make-test

In response to this:

/test ci-cert-manager-master-e2e-v1-28-feature-gates-disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj
Copy link
Member

wallrj commented Jan 12, 2024

/test pull-cert-manager-master-e2e-v1-28-feature-gates-disabled

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 12, 2024
@wallrj
Copy link
Member

wallrj commented Jan 12, 2024

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 12, 2024
wallrj
wallrj approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SpectralHiss

I ran the 1.28 feature-gates-disabled tests and they passed,
so I think you've solved the problem.

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 3d4c6d1 into cert-manager:master Jan 12, 2024
@wallrj wallrj mentioned this pull request Jan 12, 2024
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpectralHiss @jetstack-bot @wallrj