Skip to content

Fix two 'PRISMA' vulnerabilities #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix two 'PRISMA' vulnerabilities #6326

wants to merge 3 commits into from

Conversation

pmerrison
Copy link
Contributor

Pull Request Motivation

Our enterprise customers complain whenever there are vulnerabilities found in the images we ship, and don't care whether the vulnerabilities are really exploitable or not. To that end, we maintain an internal fork of cert-manager just to apply CVE fixes. I suspect that we might not be the only ones who have customers who are this demanding, so I wanted to submit these fixes upstream since others might find it as helpful to have them as we do.

Kind

Release Note

NONE

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2023
@jetstack-bot
Copy link
Contributor

Hi @pmerrison. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2023
@pmerrison
Copy link
Contributor Author

Added sign-off

@inteon
Copy link
Member

inteon commented Sep 11, 2023

Sorry to annoy you with this, but the CI wants both commits to have a signoff message. @pmerrison

@pmerrison
Copy link
Contributor Author

Sorry to annoy you with this, but the CI wants both commits to have a signoff message. @pmerrison

Ah, no worries, sorry I missed one. Will get it fixed up

@pmerrison
rebase and update
732ccc2 
Signed-off-by: Paul Merrison <paul@tetrate.io>
@pmerrison
Add update to go-restful
eea043e 
Signed-off-by: Paul Merrison <paul@tetrate.io>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 11, 2023
@inteon
Copy link
Member

inteon commented Sep 11, 2023

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2023
@inteon inteon self-assigned this Sep 11, 2023
@inteon
run 'make tidy' & 'make update-license'
a8c824e 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added the area/testing Issues relating to testing label Sep 11, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2023
@inteon
Copy link
Member

inteon commented Sep 11, 2023

/retest

@jetstack-bot
Copy link
Contributor

@pmerrison: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-e2e-v1-28 a8c824e link true /test pull-cert-manager-master-e2e-v1-28

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@inteon inteon mentioned this pull request Sep 12, 2023
Merged
@inteon
Copy link
Member

inteon commented Sep 12, 2023

Not sure why tests are failing. I tried to include the upgrades in #6332 together will a bunch of other upgrades.
I added you as a co-author in that commit.

@inteon
Copy link
Member

inteon commented Sep 12, 2023

resolved in #6332

@inteon inteon closed this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inteon inteon

Labels
area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmerrison @jetstack-bot @inteon