Skip to content

Conversation

SgtCoDFish
Copy link
Member

Pull Request Motivation

Go 1.20.4 is a security release. Nothing looks massively relevant to us in terms of security, but we should bump all the same before we release 1.12.

Kind

/kind bug

Release Note

NONE

SgtCoDFish added 2 commits May 3, 2023 10:01
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2023
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cherrypick release-1.12

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 3971774 into cert-manager:master May 3, 2023
@jetstack-bot jetstack-bot added this to the v1.12 milestone May 3, 2023
@SgtCoDFish SgtCoDFish deleted the bumpgo branch May 3, 2023 09:21
@SgtCoDFish
Copy link
Member Author

@wallrj I think the command is cherry-pick so I guess it failed?

Either way, it doesn't look to me like we've been cherrypicking commits back yet (i.e. we've been fast forwarding). Maybe we'll fast forward again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants