Skip to content

[release-1.10] Webhook solver conformance bugfix #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 19, 2023
Merged

[release-1.10] Webhook solver conformance bugfix #5739

merged 4 commits into from
Jan 19, 2023

Conversation

jetstack-bot
Copy link
Contributor

This is an automated cherry-pick of #5736

/assign SgtCoDFish

NONE

@irbekrm
A bunch of comments on webhook solver functionality
03b0e08 
With the goal of making folks working on these parts of code be aware that this is the one bit that will be imported in external projects

Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
RFC2136 solver has an init option to reset secrets lister
50b747f 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
Resets secrets lister in RFC2136 conformance tests
ebfc9c5 
The way the tests run (a new kube apiserver with a different client created for the same initialized solver) is not how this solver would actually run

Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
Code review feedback: fix imports
5028279 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot mentioned this pull request Jan 19, 2023
Merged
@jetstack-bot jetstack-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 19, 2023
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/testing Issues relating to testing needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2023
@irbekrm
Copy link
Contributor

irbekrm commented Jan 19, 2023

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@irbekrm irbekrm added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed lgtm Indicates that a PR is ready to be merged. labels Jan 19, 2023
@jetstack-bot jetstack-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jan 19, 2023
@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, jetstack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@irbekrm
Copy link
Contributor

irbekrm commented Jan 19, 2023

/kind bug

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 19, 2023
@SgtCoDFish SgtCoDFish added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@jetstack-bot jetstack-bot merged commit 83791ee into cert-manager:release-1.10 Jan 19, 2023
@jetstack-bot jetstack-bot mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SgtCoDFish SgtCoDFish

@irbekrm irbekrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/testing Issues relating to testing cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jetstack-bot @irbekrm @SgtCoDFish