Skip to content

[release-1.10] Use RenegotiateOnceAsClient in the Venafi Issuer client and explain why #5576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2022
Merged

[release-1.10] Use RenegotiateOnceAsClient in the Venafi Issuer client and explain why #5576

merged 3 commits into from
Nov 15, 2022

Conversation

jetstack-bot
Copy link
Contributor

@jetstack-bot jetstack-bot commented Nov 11, 2022 •
edited by wallrj
Loading

This is an automated cherry-pick of #5568

/assign wallrj

The Venafi Issuer now supports TLS 1.2 renegotiation, so that it can connect to TPP servers where the vedauth API endpoints are configured to *accept* client certificates. (Note: This does not mean that the Venafi Issuer supports client certificate authentication).

@wallrj
Use RenegotiateOnceAsClient and explain why
9639231 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Always initialize tlsClientConfig if the default is nil
7dcefa9 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Fix typos in explanatory comment
9a4093a 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot mentioned this pull request Nov 11, 2022
Merged
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2022
@wallrj
Copy link
Member

wallrj commented Nov 11, 2022

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2022
wallrj
wallrj approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@jetstack-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@wallrj
Copy link
Member

wallrj commented Nov 15, 2022

/kind bug
/hold cancel

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 15, 2022
@wallrj wallrj added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 15, 2022
@jetstack-bot jetstack-bot merged commit a96bae1 into cert-manager:release-1.10 Nov 15, 2022
@swghosh swghosh mentioned this pull request Jan 30, 2023
Merged
@jetstack-bot jetstack-bot mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

@wallrj wallrj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jetstack-bot @wallrj