Skip to content

Bumps dependencies #4942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2022
Merged

Bumps dependencies #4942

merged 2 commits into from
Mar 18, 2022

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Mar 14, 2022 •
edited
Loading

Pull Request Motivation

This PR should fix dependabot alerts against cert-manager repo.

Release Note

NONE

/kind cleanup

Signed-off-by: irbekrm irbekrm@gmail.com

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration labels Mar 14, 2022
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 14, 2022
@irbekrm irbekrm changed the title Bumps a bunch of deps Bumps dependencies, deprecates HMACMD5 Mar 14, 2022
SgtCoDFish
SgtCoDFish approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

Holding because of a nitpick but looks good, happy to merge!

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2022
@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Mar 15, 2022
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 15, 2022
@SgtCoDFish
Copy link
Member

/lgtm
/unhold

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 15, 2022
@munnerz
Copy link
Member

munnerz commented Mar 15, 2022

Changing the default value here is surely a breaking change, no?

Some users servers may not have support for the new default value and this would cause them to stop working unless I misunderstand the difference 👀

@munnerz
Copy link
Member

munnerz commented Mar 15, 2022

More generally speaking, changing default values is a breach of our API guarantees so certainly shouldn't be done like this.

I am +1 to deprecation, but we don't really have a clear path to removal as a policy yet (and Kubernetes itself hasn't really set a precedent for this either)

@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@cert-manager cert-manager deleted a comment from jetstack-bot Mar 16, 2022
@maelvls
Copy link
Member

maelvls commented Mar 17, 2022 •
edited
Loading

Hi! As part of the effort of migrating from Bazel to Make, we have added two new Prow jobs that require this PR to be rebased on top of master in order to pass. The two Prow jobs that were added are pull-cert-manager-make-test and pull-cert-manager-make-e2e-v1-23. Thanks! 🙏

@maelvls
Copy link
Member

maelvls commented Mar 17, 2022

/test pull-cert-manager-make-test
/test pull-cert-manager-make-e2e-v1-23

@irbekrm irbekrm mentioned this pull request Mar 17, 2022
Merged
irbekrm added 2 commits March 17, 2022 20:14
@irbekrm
Bumps a bunch of deps
ad746fa 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@irbekrm
Replaces dns v0.41 -> v0.34
587e02c 
This is so as to avoid dropping support for HMacMD5 value for issuer.spec.acme.solvers.dns01.rfc2136.tsigAlgorithm

Signed-off-by: irbekrm <irbekrm@gmail.com>
@SgtCoDFish
Copy link
Member

/approve
/lgtm

As discussed in standup. Thanks 👍

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 49e2b5a into cert-manager:master Mar 18, 2022
@jetstack-bot jetstack-bot added this to the v1.8 milestone Mar 18, 2022
@irbekrm irbekrm deleted the bump_deps branch March 30, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@irbekrm @SgtCoDFish @munnerz @jetstack-bot @maelvls