Skip to content

Rename finalizer to conform to k8s requirements #7266

@jsoref

Description

@jsoref

ACMEFinalizer = "finalizer.acme.cert-manager.io"

Identifiers of custom finalizers consist of a domain name, a forward slash and the name of the finalizer.

-- https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#finalizers

For example:
"finalizer.acme.cert-manager.io" => "acme.cert-manager.io/finalizer"

This error triggers this output:

W0910 20:07:22.491920 1 warnings.go:70] metadata.finalizers: "finalizer.acme.cert-manager.io": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions