-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Closed
Labels
kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Description
In #3208 @meyskens updated our fork of golang.org/x/crypto with a new function to fetch ACME alternative certificate chain bundles.
The fork had previously been maintained by @munnerz in his personal Github organization..
This should be a temporary fork, while we wait for our changes to be accepted by upstream.
Meanwhile:
- We should move the fork to the cert-manager organization where it can be more easily be maintained by all cert-manager team members.
- Moving it to the cert-manager org, would give more assurance to our users that the fork is carefully maintained (IMO).
- We should document in cert-manager why we are using this fork and link to upstream PRs for the changes we have made.
- The fork description should clearly explain the purpose of the fork.
- The fork should be kept up to date with the upstream repo, to ensure that we pick up bug fixes from upstream.
/kind feature
meyskens
Metadata
Metadata
Assignees
Labels
kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.