feat: add autogenerated helm docs #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6267794 to
6da4b5f
Compare
|
Hi @ThatsMrTalbot - Thanks for the feature request and the PR! We will review with the team and get back to you soon. |
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
6da4b5f to
7179246
Compare
|
It looks like the failing build has nothing to do with my change, since its failing at the go build stage and the PR does not touch any go code |
|
Build looks to have passed now, could this be looked at when you get a mo? |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no docs for the helm chart, this adds auto-generated docs using helm-tool.
Preview can be seen here:
https://github.com/ThatsMrTalbot/aws-privateca-issuer/blob/feat/helm-tool-for-docs/charts/aws-pca-issuer/README.md