Skip to content

added doc for CA name constraints #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tanujd11
Copy link
Member

@tanujd11 tanujd11 commented Dec 7, 2023

CC: @maelvls

Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2023
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 0f97866
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/6572dad37c98e3000823744f
😎 Deploy Preview https://deploy-preview-1358--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Tanuj, excellent!

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@tanujd11
Copy link
Member Author

tanujd11 commented Dec 8, 2023

Thanks @maelvls , can we now merge this and the cert-manager PR?

Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@maelvls
Copy link
Member

maelvls commented Dec 8, 2023

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@jetstack-bot jetstack-bot merged commit 8b16744 into cert-manager:release-next Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants