Skip to content

Fix Azure AKS tutorial file downloads #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2023
Merged

Fix Azure AKS tutorial file downloads #1140

merged 3 commits into from
Jan 11, 2023

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jan 10, 2023 •
edited
Loading

I forgot to rename the directory containing the downloadable manifest files in #1120
The yaml download links are now fixed, e.g.

I tried to use the file=../../../../public/... but it fails with e.g. ENOENT: no such file or directory, open '/home/prow/go/src/github.com/cert-manager/website/content/public/docs/tutorials/getting-started-aks-letsencrypt/clusterissuer-selfsigned.yaml' only when building the site, but works when I run ./scripts/server-netlify so I've abandoned that for now.

/cc @SgtCoDFish

@wallrj
Rename tutorial assets folder to match the tutorial path
139a1b9 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2023
@wallrj wallrj mentioned this pull request Jan 10, 2023
Merged
@SgtCoDFish
Copy link
Member

The test failure looks legitimate to me - will review when it passes!

wallrj added 2 commits January 11, 2023 10:14
@wallrj
Add missing code block language annotation
5908f4b 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj
Fix file name
64b1352 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj force-pushed the fix-tutorial-files branch from 53c90a9 to 64b1352 Compare January 11, 2023 10:14
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2023
@netlify
Copy link

netlify bot commented Jan 11, 2023

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 64b1352
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/63be8c12e301e9000930a48b
😎 Deploy Preview https://deploy-preview-1140--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@wallrj
Copy link
Member Author

wallrj commented Jan 11, 2023

I tried to fix the file=... thing, but the relative links to my downloadable files in public/ got prepended with content/ by the remark plugin.

I spent some time trying to fix it but couldn't.

I concluded that we should switch to use the upstream version of the plugin which seems to get the included file relative to the mdx file rather than relative to the slug, which has a trailing slash and does not include the source file name.

@wallrj
Copy link
Member Author

wallrj commented Jan 11, 2023

@SgtCoDFish PTAL

SgtCoDFish
SgtCoDFish approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for this!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wallrj wallrj added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jan 11, 2023
@jetstack-bot jetstack-bot merged commit 7a7850f into cert-manager:release-next Jan 11, 2023
@jetstack-bot jetstack-bot mentioned this pull request Jan 11, 2023
Merged
@wallrj wallrj deleted the fix-tutorial-files branch January 11, 2023 14:16
@jetstack-bot jetstack-bot mentioned this pull request Jan 14, 2023
Closed
@wallrj wallrj mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wallrj @SgtCoDFish @jetstack-bot