Skip to content

Adds tests for release-1.12 and kube 1.27 #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Adds tests for release-1.12 and kube 1.27 #883

merged 1 commit into from
Apr 24, 2023

Conversation

irbekrm
Copy link
Contributor

@irbekrm irbekrm commented Apr 24, 2023 •
edited
Loading

This PR does the work required to add release-1.12 tests and test release-1.12, release-1.11 and current master with kube 1.27:

  • adds release-1.12 tests to prowjob codegen
  • updates prowjob codegen config for master to test on 1.27 by default
  • generates prowjob configs with the two changes listed above
  • adds release-1.12 tests as required tests for cherry-picks against release-1.12 branch
  • adds kube 1.27 test for release-1.11
  • removes a couple out of date things like refs to release-1.9 tests

1.27 kind images were added in cert-manager/cert-manager#5979 and fast forwarded to release-1.12 branch

@irbekrm
Adds tests for release-1.12 and kube 1.27
dd10d0d 
Signed-off-by: irbekrm <irbekrm@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 24, 2023
inteon
inteon approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, irbekrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit fe31574 into cert-manager:master Apr 24, 2023
@jetstack-bot
Copy link
Contributor

@irbekrm: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
    • key cert-manager-release-1.11.yaml using file config/jobs/cert-manager/cert-manager/release-1.11/cert-manager-release-1.11.yaml
    • key cert-manager-release-1.12.yaml using file config/jobs/cert-manager/cert-manager/release-1.12/cert-manager-release-1.12.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml

In response to this:

This PR does the work required to add release-1.12 tests and test with kube 1.27:

  • adds release-1.12 tests to prowjob codegen
  • updates prowjob codegen config for master to test on 1.27 by default
  • generates prowjob configs with the two changes listed above
  • adds release-1.12 tests as required tests for cherry-picks against release-1.12 branch
  • removes a couple out of date things like refs to release-1.9 tests

1.27 kind images were added in cert-manager/cert-manager#5979 and fast forwarded to release-1.12 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irbekrm irbekrm deleted the release_112_kube_127 branch April 25, 2023 05:08
@irbekrm irbekrm mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon approved these changes

Assignees

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irbekrm @jetstack-bot @inteon