fix: allow plugins to have scope #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR is ready now! In future iterations it would be nice to refactor readdir, readfile... to their async methods to avoid performance issues. |
ogustavo-pereira
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the regex:
If base (the folder to treat as a plugin) matches node_modules or a scope (@) named folder, returns, as they must not be loaded as plugins. --> Ignore
node_modulesas the folder that should load is/node_modules/plugin-folderor/@scope/plugin-nameDir (the parent folder of the plugin folder) must be node_modules or a scope named folder (to ignore scanned folders inside a plugin) --> Ignore
/plugin-folder/subfolderas the plugin must be required from the root folder of the pluginfix #468