Fix breaking changes changes made in 1.12 and leftovers #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR, would you mind resolving the conflicts? |
|
@techknowlogick done. |
|
@roman-vynar much appreciated, thanks!! 😊 |
techknowlogick
approved these changes
Jun 10, 2024
|
@techknowlogick could this maybe be released? As far as I can see, the current Docker image is broken for OIDC usage without these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix breaking changes changes made in 1.12 and leftovers:
http_timeout: 10becamehttp_timeout: "10s"in the samples, otherwise it will be nanoseconds and impossible to do Google auth etc. Nothing mentioned in the changelog.token_dbconfig string becamelevel_token_db.pathin the samples. Nothing mentioned in the changelog.level_token_db.pathwas set but docker_auth still complaining it is not.