Skip to content

Conversation

Furtif
Copy link
Collaborator

@Furtif Furtif commented Jan 16, 2024

@cedricp look if good. Thanks!

@Furtif Furtif requested a review from cedricp January 16, 2024 10:21
@cedricp
Copy link
Owner

cedricp commented Jan 16, 2024

Looks right, but has it been tested ?

@Furtif Furtif mentioned this pull request Jan 16, 2024
Closed
@Furtif
Copy link
Collaborator Author

Furtif commented Jan 16, 2024

All TODO issues:

// TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/EcuTweaker/build.gradle#L27
// TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/EcuTweaker/src/main/java/org/quark/dr/canapp/ElmBase.java#L281
// TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/EcuTweaker/src/main/java/org/quark/dr/canapp/ElmBase.java#L310
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/EcuTweaker/src/main/java/org/quark/dr/canapp/ElmBase.java#L312
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/EcuTweaker/src/main/java/org/quark/dr/canapp/MainActivity.java#L439
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/EcuTweaker/src/main/java/org/quark/dr/canapp/MainActivity.java#L444
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/EcuTweaker/src/main/java/org/quark/dr/canapp/MainActivity.java#L449
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/ecu/src/main/java/org/quark/dr/ecu/ZipFileSystem.java#L100
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/CdcAcmSerialDriver.java#L289
//TODO; https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/CdcAcmSerialDriver.java#L355
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/CdcAcmSerialDriver.java#L360
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/CdcAcmSerialDriver.java#L365
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/CdcAcmSerialDriver.java#L381
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/Ch34xSerialDriver.java#L137
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/Ch34xSerialDriver.java#L303
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/FtdiSerialDriver.java#L186
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/FtdiSerialDriver.java#L237
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/FtdiSerialDriver.java#L427
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/FtdiSerialDriver.java#L453
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/driver/FtdiSerialDriver.java#L501
//TODO: https://github.com/cedricp/ecutweaker/blob/fix_29bits/usbserial/src/main/java/org/quark/dr/usbserial/util/SerialInputOutputManager.java#L123

@Furtif Furtif merged commit 5a2d9aa into master Jan 16, 2024
@Furtif Furtif deleted the fix_29bits branch January 16, 2024 22:11
@Furtif Furtif restored the fix_29bits branch January 16, 2024 22:11
@Furtif Furtif deleted the fix_29bits branch February 4, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

29
2 participants