Improve substitution #1387
Merged
Improve substitution #1387
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lőrinc Bódy <lorinc.body@devrev.ai>
9099469 to
ac7de7d
Compare
|
LGTM. Nit: I prefer the new API to be named like |
shaobo-he-aws
approved these changes
Dec 20, 2024
I can do that. |
Yes, we theoretically can. You can go ahead to mark it in the PR and other team members can weigh in when they review it. |
propose deprecation of old reauthorize Signed-off-by: Lőrinc Bódy <lorinc.body@devrev.ai>
john-h-kastner-aws
approved these changes
Dec 31, 2024
|
|
||
| /// Attempt to re-authorize this response given a mapping from unknowns to values, provided as an iterator. | ||
| /// Exhausts the iterator, returning any evaluation errors in the restricted expressions, regardless whether there is a matching unknown. | ||
| pub fn reauthorize_with_bindings<'m>( |
There was a problem hiding this comment.
Does it need this explicit lifetime?
There was a problem hiding this comment.
Without it, I get an error:
anonymous lifetimes in `impl Trait` are unstable
expected named lifetime parameter
api.rs(1075, 51): consider introducing a named lifetime parameter: `'a `, `<'a>`
shaobo-he-aws
added a commit
to cedar-policy/cedar-examples
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Shaobo He <shaobohe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a new function
reauthorize_with_itertoPartialResponse, that takes anIntoIteratorinstead of theHashMap<SmolString, RestrictedExpression>. This has two advantages:reauthorizeimmediately consumes the hashmap, the new api removes the need to allocate it if the remappings are already available in some other format.I'm considering to add one that takes a Fn(&str) -> Option too, that one would remove the need to iterate them all.
In fact the whole substitution infrastructure in -core could be using such a function, but the current reauthorize API is not (easily) implementable in those terms, because of the fallibility of conversion from RestrictedExpression to Value.
However, I believe the most common case will be when the caller provides literal types in the substitutions: If we make a specialized method that takes only valid values, the need to evaluate the 'restricted expression' disappears.
But I suppose ast::Value shoudn't be exposed in the public API, instead EvalResult or a similar wrapper would be needed?
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):