Add new_datetime
and new_duration
methods to Expression
and RestrictedExpression
#1614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds
Expression::new_duration
,Expression::new_datetime
,RestrictedExpression::new_duration
andRestrictedExpression::new_datetime
methods to the public API. These are analogous to the existingnew_ip
, etc. methods for constructing expressions with extension function values, but for the newdatetime
andduration
types from RFC 80.It also corrects some incorrect uses of
assert_matches!
in unit tests for the oldnew_ip
andnew_decimal
functions.Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy
(e.g., addition of a new API).I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec
(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com
(choose one, and delete the other options):