Skip to content

Bump MSRV to 1.82 #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Bump MSRV to 1.82 #1611

merged 1 commit into from
May 15, 2025

Conversation

shaobo-he-aws
Copy link
Contributor

@shaobo-he-aws shaobo-he-aws commented May 12, 2025 •
edited
Loading

Description of changes

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.

@shaobo-he-aws
Bump MSRV to 1.82
ad0edf2 
Signed-off-by: Shaobo He <shaobohe@amazon.com>
@github-actions GitHub Actions
Copy link

Coverage Report

Head Commit: ad0edf240d0d08a73c46058f3acda5b9be3050f9

Base Commit: e0eadeae8cb9e5abdd21e5a35880d5ddefa759b3

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 100.00%

Status: PASSED ✅

Details
File Status Covered Coverage Missed Lines

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 81.74%

Status: PASSED ✅

Details
Package Status Covered Coverage Base Coverage
cedar-policy 🔴 3111/4528 68.71% --
cedar-policy-cli 🔴 571/972 58.74% --
cedar-policy-core 🟢 11974/14209 84.27% --
cedar-policy-formatter 🟢 914/1043 87.63% --
cedar-policy-validator 🟢 8841/10307 85.78% --
cedar-wasm 🔴 0/29 0.00% --

@adpaco-aws
Copy link
Contributor

Looks like there's an issue with the WASM bindings?

@shaobo-he-aws
Copy link
Contributor Author

Looks like there's an issue with the WASM bindings?

Reran it and passed

@john-h-kastner-aws john-h-kastner-aws merged commit 5226176 into main May 15, 2025
28 of 29 checks passed
@shaobo-he-aws shaobo-he-aws deleted the chore/shaobo/bump-versions branch May 15, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdisselkoen cdisselkoen cdisselkoen approved these changes

@katherine-hough katherine-hough katherine-hough approved these changes

@john-h-kastner-aws john-h-kastner-aws Awaiting requested review from john-h-kastner-aws

@adpaco-aws adpaco-aws Awaiting requested review from adpaco-aws

@chaluli chaluli Awaiting requested review from chaluli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shaobo-he-aws @adpaco-aws @cdisselkoen @katherine-hough @john-h-kastner-aws