Refactor entity conformance checking #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes a bug where Cedar doesn't performance checks on tags. Signed-off-by: Shaobo He <shaobohe@amazon.com>
chaluli
approved these changes
May 8, 2025
Coverage ReportHead Commit: Base Commit: Download the full coverage report. Coverage of Added or Modified Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 82.99% Status: PASSED ✅ Details
Coverage of All Lines of Rust CodeRequired coverage: 80.00% Actual coverage: 81.76% Status: PASSED ✅ Details
|
john-h-kastner-aws
approved these changes
May 8, 2025
| @@ -2189,6 +2190,57 @@ action "g" appliesTo { | |||
| "#; | |||
| assert_matches!(Entity::from_json_str(entity_str, Some(&schema)), Ok(_)); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn from_entities_tags() { | |||
There was a problem hiding this comment.
Should probably include a test that conformance check succeeds if the correct type of tag is provided.
There was a problem hiding this comment.
Will do it in another PR so that I can use the APIs now.
shaobo-he-aws
added a commit
that referenced
this pull request
May 12, 2025
Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws
added a commit
that referenced
this pull request
May 12, 2025
This commit also added a couple of positive test cases. Signed-off-by: Shaobo He <shaobohe@amazon.com>
shaobo-he-aws
added a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also fixes a bug where Cedar doesn't performance checks on tags.
Description of changes
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
cedar-policy.I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):