Better testing #1170
Merged
Better testing #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Test coverage +0.84%: https://app.codecov.io/gh/cdk/cdk/pull/1170/indirect-changes |
johnmay
reviewed
Mar 16, 2025
| @@ -44,5 +44,6 @@ void testEthane() throws Exception { | |||
| ValidationReport report = engine.validateChemFile(chemFile); | |||
| Assertions.assertEquals(0, report.getErrorCount()); | |||
| Assertions.assertEquals(0, report.getWarningCount()); | |||
| reader.close(); | |||
There was a problem hiding this comment.
All ok but this could be better written as:
try (MDLV2000Reader reader = new MDLV2000Reader(ins, Mode.STRICT)) {
ChemFile chemFile = (ChemFile) reader.read((ChemObject) new ChemFile());
ValidatorEngine engine = new ValidatorEngine();
engine.addValidator(new Geometry3DValidator());
ValidationReport report = engine.validateChemFile(chemFile);
Assertions.assertEquals(0, report.getErrorCount());
Assertions.assertEquals(0, report.getWarningCount());
}
johnmay
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-moduleto justmoduleReader