migrate FormatStringBuffer to FormatStringBuilder #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
uli-f
commented
Feb 9, 2025
- replace StringBuffer with StringBuilder for improved performance
- update dependencies and related test classes accordingly
- simplified code and removed code smells
…r with StringBuilder for improved performance; update dependencies and related test classes accordingly; simplified code and removed code smells
egonw
requested changes
Feb 9, 2025
There was a problem hiding this comment.
I would suggest to not to rename the class. Even the internal variable name (buffer) does not have to be changed. It only makes the patch much larger. But if @johnmay is okay with it, I will also not block the PR because of that. And I also feel the pain of the work done on the renaming.
base/standard/src/main/java/org/openscience/cdk/tools/FormatStringBuilder.java
Outdated
Show resolved
Hide resolved
… make FormatStringBuilder package-private; update constructors and methods to package-private; remove unused imports for FormatStringBuilder in related classes
|
@johnmay Moved |
johnmay
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.