Add the option to locate a IChemObject builder using reflection. Enfo… #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce the RDfile reader has one.
|
Looks good. Same as for the other PR, for 2.10.x or 2.11? |
uli-f
suggested changes
Jan 10, 2025
| @@ -137,7 +137,7 @@ public RdfileReader(InputStream in, IChemObjectBuilder chemObjectBuilder, boolea | |||
| * @param reader the Reader providing the RDfile data | |||
| */ | |||
| public RdfileReader(Reader reader) { | |||
There was a problem hiding this comment.
This method signature looks like an oversight on my end, my apologies. Looking at the javadocs it states that it takes an IChemObjectBuilder; moreover, both constructors that accept an InputStream also require an IChemObjectBuilder.
Suggestion: I would mark this constructor @deprecated and add a new one:
public RdfileReader(Reader reader, IChemObjectBuilder chemObjectBuilder) {
this(reader, chemObjectBuilder, true);
}
Comment on lines
21
to
24
| import org.openscience.cdk.tools.LoggingToolFactory; | ||
|
|
||
| import java.lang.reflect.InvocationTargetException; | ||
| import java.lang.reflect.Method; |
|
uli-f
approved these changes
Jan 10, 2025
storage/ctab/src/main/java/org/openscience/cdk/io/RdfileReader.java
Outdated
Show resolved
Hide resolved
|
I think we still have the IChemObjectBuilder cache as Egon and I had considered this previously. @egonw good to merge if you like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rce the RDfile reader has one.
Different Java version's didn't like a piece of code the the RDfile reader constructor - I spotted it when I wrote the sample code for the release and accidentally committed it here: f351dd0#diff-c8b0d51b33ab2fde91ce878d3b9887e6063201b65be2fa98b6a842643a4b4fceL138-R140.
I have added the option for the IChemObjectBuilder to look one up via reflection, @egonw and I have talked about this previously.