-
Notifications
You must be signed in to change notification settings - Fork 170
Improved Abbreviation Handling #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can still be controlled with the appropriate option.
…eviation we are attempting to make. This allow us to automatically generate better abbreviations like Et3P instead of PEt3 (carbons come first). Also add in the option to turn on/off linker contractions
… abbreviations on those atoms. This is useful for highlighting.
Kudos, SonarCloud Quality Gate passed! |
Looks good to me. Thanks for the clear tests! |
Right time for a release I think |
@johnmay, yeah, it's been a year. Very much supporting this idea! |
I do intend to do them more frequently… stuff just gets in the way |
Yeah, I know how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to the Abbreviation algorithm, options, and functionality.
Et3P
andPh2
factory.with(Abbreviations.Option.ALLOW_SINGLETON); factory.without(Abbreviations.Option.AUTO_CONTRACT_TERMINAL);