Fix output of alpha channel floats #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmay
reviewed
Jun 7, 2022
app/depict/src/main/java/org/openscience/cdk/depict/SvgDrawVisitor.java
Outdated
Show resolved
Hide resolved
|
Shall we just put the sonar cloud key in the GH action? |
Only as a hidden key in the GitHub organization and then use |
|
Well that's what we have, the issue is even you can't get it to run with a PR from a branch in your fork |
|
I think there is a way to do it with GITHUB_TOKEN instead of SONAR_TOKEN... where by user details allow access control |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #860