Fix a v. subtle issue in up/down bond handling in SMILES. It's quite … #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a corner case but it turns out some toolkits do write records like this (found one in ChEMBL). Only happens if the bond is written on the ring open (unusual but ok) and then multiple directional bonds are written. BEAM does more in recent releases to check/ignore innconsitent behaviour allready but we can add the correct check in the BEAM2CDK conversion.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a corner case but it turns out some toolkits do write records like this (found one in ChEMBL). Only happens if the bond is written on the ring open (unusual but ok) and then multiple directional bonds are written. BEAM does more in recent releases to check/ignore innconsitent behaviour allready but we can add the correct check in the BEAM2CDK conversion.