This code is deprecated we don't need the full Desctiptor basic checks. Note it may make sense to move the descriptor interfaces to CDK interfacts then the descriptor tests can go to into cdk-test.

johnmay · egonw · commit 08a15e862572 · 2021-12-24T09:03:56.000+01:00
diff --git a/legacy/pom.xml b/legacy/pom.xml
@@ -178,21 +178,6 @@
             <artifactId>cdk-qsaratomic</artifactId>
             <version>${project.version}</version>
             <scope>test</scope>
-            <type>test-jar</type>
-        </dependency>
-        <dependency>
-            <groupId>org.openscience.cdk</groupId>
-            <artifactId>cdk-qsarbond</artifactId>
-            <version>${project.version}</version>
-            <scope>test</scope>
-            <type>test-jar</type>
-        </dependency>
-        <dependency>
-            <groupId>org.openscience.cdk</groupId>
-            <artifactId>cdk-qsarmolecular</artifactId>
-            <version>${project.version}</version>
-            <scope>test</scope>
-            <type>test-jar</type>
         </dependency>
         <dependency>
             <groupId>org.mockito</groupId>
diff --git a/legacy/src/test/java/org/openscience/cdk/qsar/descriptors/atomic/IPAtomicLearningDescriptorTest.java b/legacy/src/test/java/org/openscience/cdk/qsar/descriptors/atomic/IPAtomicLearningDescriptorTest.java
@@ -23,6 +23,7 @@
 import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.openscience.cdk.CDKTestCase;
 import org.openscience.cdk.DefaultChemObjectBuilder;
 import org.openscience.cdk.SlowTest;
 import org.openscience.cdk.exception.CDKException;
@@ -42,7 +43,7 @@
  *
  * @cdk.module test-qsarionpot
  */
-public class IPAtomicLearningDescriptorTest extends AtomicDescriptorTest {
+public class IPAtomicLearningDescriptorTest extends CDKTestCase {
 
     IPAtomicLearningDescriptor      descriptor;
     private SmilesParser            sp      = new SmilesParser(DefaultChemObjectBuilder.getInstance());
@@ -59,7 +60,7 @@ public IPAtomicLearningDescriptorTest() {
 
     @Before
     public void setUp() throws Exception {
-        setDescriptor(IPAtomicLearningDescriptor.class);
+        descriptor = new IPAtomicLearningDescriptor();
     }
 
     /**
diff --git a/legacy/src/test/java/org/openscience/cdk/qsar/descriptors/bond/IPBondLearningDescriptorTest.java b/legacy/src/test/java/org/openscience/cdk/qsar/descriptors/bond/IPBondLearningDescriptorTest.java
@@ -23,6 +23,7 @@
 import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.openscience.cdk.CDKTestCase;
 import org.openscience.cdk.DefaultChemObjectBuilder;
 import org.openscience.cdk.SlowTest;
 import org.openscience.cdk.interfaces.IAtomContainer;
@@ -36,7 +37,7 @@
  *
  * @cdk.module test-qsarionpot
  */
-public class IPBondLearningDescriptorTest extends BondDescriptorTest {
+public class IPBondLearningDescriptorTest extends CDKTestCase {
 
     private IPBondLearningDescriptor descriptor;
     private LonePairElectronChecker  lpcheck = new LonePairElectronChecker();
@@ -51,7 +52,7 @@ public IPBondLearningDescriptorTest() {
 
     @Before
     public void setUp() throws Exception {
-        setDescriptor(IPBondLearningDescriptor.class);
+        descriptor = new IPBondLearningDescriptor();
     }
 
     /**
diff --git a/legacy/src/test/java/org/openscience/cdk/qsar/descriptors/molecular/IPMolecularLearningDescriptorTest.java b/legacy/src/test/java/org/openscience/cdk/qsar/descriptors/molecular/IPMolecularLearningDescriptorTest.java
@@ -22,6 +22,7 @@
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
+import org.openscience.cdk.CDKTestCase;
 import org.openscience.cdk.DefaultChemObjectBuilder;
 import org.openscience.cdk.SlowTest;
 import org.openscience.cdk.interfaces.IAtom;
@@ -41,8 +42,9 @@
  *
  * @cdk.module test-qsarionpot
  */
-public class IPMolecularLearningDescriptorTest extends MolecularDescriptorTest {
+public class IPMolecularLearningDescriptorTest extends CDKTestCase {
 
+    IPMolecularLearningDescriptor descriptor;
     private SmilesParser            sp      = new SmilesParser(DefaultChemObjectBuilder.getInstance());
     private IChemObjectBuilder      builder = SilentChemObjectBuilder.getInstance();
     private LonePairElectronChecker lpcheck = new LonePairElectronChecker();
@@ -55,7 +57,7 @@ public IPMolecularLearningDescriptorTest() {}
 
     @Before
     public void setUp() throws Exception {
-        super.setDescriptor(IPMolecularLearningDescriptor.class);
+        descriptor = new IPMolecularLearningDescriptor();
     }
 
     @Test
