🐛 Exclude ClusterComplete from simulation engine selection when ALGLIB is disabled #700
Conversation
Signed-off-by: GitHub Actions <actions@github.com>
include/fiction/algorithms/simulation/sidb/critical_temperature.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/simulation/sidb/sidb_simulation_engine.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Thanks a lot! It looks good the way it is, now that all the work is done already. Though I think it would have been an easier fix and perhaps just as maintainable to only put
#else // FICTION_ALGLIB_ENABLED
assert(false && "ALGLIB must be enabled if ClusterComplete is to be used");
#endif // FICTION_ALGLIB_ENABLEDon the place where it was missing. Although, it might not help when in Release mode, I guess that is the problem since a user won't be getting any error message then.
In short, thanks a lot, looks good!
include/fiction/algorithms/simulation/sidb/sidb_simulation_engine.hpp
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 98.20% 98.20% -0.01%
==========================================
Files 255 255
Lines 42229 42229
Branches 1949 1948 -1
==========================================
- Hits 41471 41469 -2
- Misses 758 760 +2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
This PR ensures that ClusterComplete cannot be selected as the simulation engine when ALGLIB is disabled.
Checklist: