-
Notifications
You must be signed in to change notification settings - Fork 28
🎨 Improved usability of the on-the-fly SiDB gate library #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Improved usability of the on-the-fly SiDB gate library #634
Conversation
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
Signed-off-by: GitHub Actions <actions@github.com>
# Conflicts: # bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp
Signed-off-by: GitHub Actions <actions@github.com>
… into make_on_the_fly_more_accessible
@marcelwa I would love to hear your feedback when your time allows it! |
I'm on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As before, just a few minor comments here and there. Should be quick to address.
docs/algorithms/on_the_fly_circuit_design_on_defective_surface.rst
Outdated
Show resolved
Hide resolved
# Conflicts: # experiments/operational_domain/operational_domain_bestagon_grid_vs_sketch.cpp
Signed-off-by: GitHub Actions <actions@github.com>
include/fiction/algorithms/physical_design/apply_gate_library.hpp
Outdated
Show resolved
Hide resolved
include/fiction/algorithms/physical_design/apply_gate_library.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <actions@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Many thanks for the hard work on this PR!
Description
This PR improves the usability of the on-the-fly SiDB gate library. Additionally, several bugs have been fixed.
Checklist: