Skip to content

Conversation

Drewniok
Copy link
Collaborator

Description

This PR improves the usability of the on-the-fly SiDB gate library. Additionally, several bugs have been fixed.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Jan 15, 2025
@Drewniok Drewniok self-assigned this Jan 15, 2025
Drewniok and others added 5 commits January 15, 2025 17:12
# Conflicts:
#	bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp
Signed-off-by: GitHub Actions <actions@github.com>
@Drewniok
Copy link
Collaborator Author

Drewniok commented Feb 7, 2025

@marcelwa I would love to hear your feedback when your time allows it!

@marcelwa
Copy link
Collaborator

marcelwa commented Feb 7, 2025

@marcelwa I would love to hear your feedback when your time allows it!

I'm on it.

Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before, just a few minor comments here and there. Should be quick to address.

@Drewniok Drewniok requested a review from marcelwa March 21, 2025 09:54
Drewniok and others added 2 commits March 21, 2025 16:52
Signed-off-by: GitHub Actions <actions@github.com>
@Drewniok Drewniok requested a review from marcelwa March 24, 2025 17:08
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Many thanks for the hard work on this PR!

@marcelwa marcelwa merged commit 0ee0f3d into cda-tum:main Mar 25, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants