Skip to content

✨ ABC Callback #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 9, 2025
Merged

✨ ABC Callback #605

merged 20 commits into from
Jan 9, 2025

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Dec 5, 2024 •
edited
Loading

Description

This PR adds an optional callback to ABC to fiction's CLI.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the enhancement New feature or request label Dec 5, 2024
@marcelwa marcelwa self-assigned this Dec 5, 2024
github-actions[bot]
github-actions bot reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (65ccc40) to head (cbe7236).
Report is 124 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #605   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         232      232           
  Lines       35410    35410           
  Branches     1691     1691           
=======================================
  Hits        34745    34745           
  Misses        664      664           
  Partials        1        1

see 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ccc40...cbe7236. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

marcelwa and others added 12 commits December 11, 2024 10:34
@marcelwa
🐛 Limit ABC callback to AIGs and XAGs due to issues with MIGs and tec…
b64d8af 
…hnology networks
@marcelwa
🐛 Add the -s flag to ABC's write_aiger call to retain input/outpu…
e8f8078 
…t names
@marcelwa
🔥 Remove debug output
6652a3d
@marcelwa
📝 Add a help string to the ABC call
04d5ebd
@actions-user
📝 Update pyfiction docstrings
f9de98a 
Signed-off-by: GitHub Actions <actions@github.com>
@marcelwa
🔊 Silence ABC output
e6a23d5
@marcelwa
Merge remote-tracking branch 'origin/abc-callback' into abc-callback
17b2bd5
@marcelwa
✨ Add flags to omit reading, strashing, or writing in ABC
325625f
@marcelwa
🏗️ Move equiv command to the logic CLI category
fcbb803
@marcelwa
📝 Add a short mention about ABC to the README
8513343
@marcelwa
Merge branch 'main' into abc-callback
921757b 
Signed-off-by: Marcel Walter <marcel.walter@tum.de>
@pre-commit-ci
🎨 Incorporated pre-commit fixes
774b488
github-actions[bot]
github-actions bot reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

simon1hofmann
simon1hofmann approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@simon1hofmann simon1hofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the addition, just tested the abc callback again and it works without any issues.

@marcelwa marcelwa merged commit f2264fd into main Jan 9, 2025
45 checks passed
@marcelwa marcelwa deleted the abc-callback branch January 9, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@simon1hofmann simon1hofmann simon1hofmann approved these changes

@hibenj hibenj Awaiting requested review from hibenj

Assignees

@marcelwa marcelwa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelwa @simon1hofmann @actions-user