🎨 Refactored QuickSim to remove magic number for upper limit calculation
#679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickSim to remove magic number for upper limit calculationQuickSim to remove magic number for upper limit calculation
QuickSim to remove magic number for upper limit calculationQuickSim to remove magic number for upper limit calculation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
- Coverage 98.41% 98.40% -0.01%
==========================================
Files 254 254
Lines 41149 41167 +18
Branches 1869 1871 +2
==========================================
+ Hits 40495 40511 +16
- Misses 654 656 +2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
marcelwa
requested changes
Feb 25, 2025
experiments/sidb_simulation/electrostatic_ground_state/runtime_analysis_bestagon_gates.cpp
Outdated
Show resolved
Hide resolved
marcelwa
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a minor refactor of QuickSim. The key update involves removing the hardcoded number
1.5in the upper limit calculation, which was originally implemented to accelerate the simulation of SiDB gates. While this approach proved effective in most scenarios, it could lead to rare edge cases causing unexpected behavior. To enhance reliability, this adjustment eliminates the magic number. Importantly, the overall performance remains significantly improved compared to the results presented in QuickSim: Efficient and Accurate Physical Simulation of Silicon Dangling Bond Logic (https://ieeexplore.ieee.org/document/10231266).Checklist: