Skip to content

🎨 Refactored random layout design functions #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 27, 2025
Merged

🎨 Refactored random layout design functions #678

merged 16 commits into from
Feb 27, 2025

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Feb 24, 2025 •
edited
Loading

Description

This PR refactors the functions responsible for designing random SiDB layouts. If the design process fails, std::nullopt is now returned instead of an empty layout.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Feb 24, 2025
@Drewniok Drewniok self-assigned this Feb 24, 2025
github-actions[bot]
github-actions bot reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 78. Check the log or trigger a new build to see more.

@Drewniok Drewniok requested a review from marcelwa February 24, 2025 11:15
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.31183% with 5 lines in your changes missing coverage. Please review.

Project coverage is 98.39%. Comparing base (fb71178) to head (ed8c924).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/algorithms/physical_design/design_sidb_gates.hpp 70.00% 3 Missing ⚠️
...s/simulation/sidb/random_sidb_layout_generator.hpp 91.30% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   98.41%   98.39%   -0.02%     
==========================================
  Files         254      254              
  Lines       41149    41203      +54     
  Branches     1869     1871       +2     
==========================================
+ Hits        40495    40541      +46     
- Misses        654      662       +8
Files with missing lines Coverage Δ
...s/simulation/sidb/random_sidb_layout_generator.cpp 95.42% <100.00%> (+0.51%) ⬆️
...s/simulation/sidb/random_sidb_layout_generator.hpp 95.65% <91.30%> (+3.34%) ⬆️
...n/algorithms/physical_design/design_sidb_gates.hpp 97.44% <70.00%> (-1.27%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8fc98c...ed8c924. Read the comment docs.

@Drewniok Drewniok requested a review from marcelwa February 24, 2025 13:04
marcelwa
marcelwa requested changes Feb 25, 2025
View reviewed changes
Drewniok and others added 2 commits February 25, 2025 17:51
@Drewniok
🎨 implement Marcel's feedback.
18236d6
@actions-user
📝 Update pyfiction docstrings
d52757e 
Signed-off-by: GitHub Actions <actions@github.com>
@Drewniok
Copy link
Collaborator Author

Thank you for the quick review! 🙏

@Drewniok Drewniok requested a review from marcelwa February 25, 2025 17:07
marcelwa
marcelwa requested changes Feb 25, 2025
View reviewed changes
@Drewniok Drewniok requested a review from marcelwa February 27, 2025 09:15
@actions-user
📝 Update pyfiction docstrings
4ce00a9 
Signed-off-by: GitHub Actions <actions@github.com>
@Drewniok Drewniok merged commit e356987 into cda-tum:main Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@marcelwa marcelwa marcelwa approved these changes

Assignees

@Drewniok Drewniok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drewniok @marcelwa @actions-user