Skip to content

✅ Added test for issue #667 #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 10, 2025
Merged

✅ Added test for issue #667 #668

merged 11 commits into from
Apr 10, 2025

Conversation

wlambooy
Copy link
Collaborator

Description

Adds a test to try to catch the failure described in #667 .

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@wlambooy wlambooy changed the title 🐍 Added test for issue #667 ✅ Added test for issue #667 Feb 13, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 13, 2025
View reviewed changes
@wlambooy wlambooy requested a review from Drewniok February 17, 2025 07:39
Drewniok
Drewniok reviewed Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@Drewniok Drewniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test so quickly! I only found a couple of minor things.

@Drewniok
Copy link
Collaborator

@wlambooy, It would be great if you could finish this when you find the time. Thank you!

@marcelwa
Copy link
Collaborator

marcelwa commented Apr 7, 2025

@wlambooy, It would be great if you could finish this when you find the time. Thank you!

@wlambooy quick reminder of @Drewniok's comment. Would be great to merge this PR soon.

wlambooy and others added 5 commits April 8, 2025 09:33
@wlambooy
🎨 Implemented Jan's comments
00e61dd
@wlambooy
Merge remote-tracking branch 'origin/added-test-for-issue-#667' into …
ac6258d 
…added-test-for-issue-#667
@wlambooy
Merge remote-tracking branch 'origin/main' into added-test-for-issue-#…
9a0a1c8 
…667

# Conflicts:
#	bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_quickexact.py
@pre-commit-ci
🎨 Incorporated pre-commit fixes
100900c
@wlambooy @Drewniok
Update bindings/mnt/pyfiction/test/algorithms/simulation/sidb/test_qu…
d9b0166 
…ickexact.py

Co-authored-by: Jan Drewniok <jan.drewniok.research@gmail.com>
Signed-off-by: Willem Lambooy <35612535+wlambooy@users.noreply.github.com>
@Drewniok
Copy link
Collaborator

Drewniok commented Apr 9, 2025

@wlambooy, are you done?

@wlambooy wlambooy requested a review from Drewniok April 9, 2025 11:49
@wlambooy
Copy link
Collaborator Author

wlambooy commented Apr 9, 2025

I am. I was already earlier but Marcel needed to re-run the readthedocs build due to a failure with the "commit suggestion" button

Drewniok
Drewniok approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@Drewniok Drewniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@marcelwa marcelwa added the test Tests added or missing label Apr 10, 2025
@marcelwa marcelwa merged commit cfbda3a into main Apr 10, 2025
16 checks passed
@marcelwa marcelwa deleted the added-test-for-issue-#667 branch April 10, 2025 14:41
@marcelwa marcelwa mentioned this pull request Apr 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

@Drewniok Drewniok Drewniok approved these changes

Assignees

@wlambooy wlambooy

Labels
test Tests added or missing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wlambooy @Drewniok @marcelwa