Skip to content

✨ gold with discretionary cost objectives #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Sep 15, 2024
Merged

✨ gold with discretionary cost objectives #525

merged 27 commits into from
Sep 15, 2024

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Sep 9, 2024 •
edited
Loading

Description

Graph-oriented layout design with discretionary cost objectives.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann added the enhancement New feature or request label Sep 9, 2024
@simon1hofmann simon1hofmann self-assigned this Sep 9, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (ffeff24) to head (d13581f).
Report is 81 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
- Coverage   98.17%   98.17%   -0.01%     
==========================================
  Files         224      224              
  Lines       31439    31602     +163     
  Branches     1564     1575      +11     
==========================================
+ Hits        30865    31024     +159     
- Misses        574      578       +4
Files with missing lines Coverage Δ
...s/physical_design/graph_oriented_layout_design.hpp 100.00% <100.00%> (ø)
...s/physical_design/graph_oriented_layout_design.cpp 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffeff24...d13581f. Read the comment docs.

github-actions[bot]
github-actions bot reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@marcelwa
Copy link
Collaborator

clang-tidy made some suggestions

I would qualify these latest clang-tidy suggestions as "false positives" because REQUIRE does indeed sufficiently check for the std::optional's value. I therefore marked them as resolved.

marcelwa
marcelwa requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for these great additions and the quick implementation. I love the code. It reads super nicely and everything is well-documented. Amazing work! There are a few suggestions and comments I would like to bring up, though.

github-actions[bot]
github-actions bot reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-actions[bot]
github-actions bot reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@marcelwa marcelwa merged commit 2957b0c into cda-tum:main Sep 15, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@marcelwa marcelwa marcelwa approved these changes

Assignees

@simon1hofmann simon1hofmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon1hofmann @marcelwa @actions-user